Remove geometry related code in encode-mtg2 action and grib1-to-grib2 tool#247
Open
Remove geometry related code in encode-mtg2 action and grib1-to-grib2 tool#247
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #247 +/- ##
===========================================
+ Coverage 55.81% 56.35% +0.54%
===========================================
Files 325 321 -4
Lines 21372 21141 -231
Branches 1692 1679 -13
===========================================
- Hits 11928 11915 -13
+ Misses 9444 9226 -218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dsarmany
force-pushed
the
feature/mars2grib-grid-refactor
branch
from
6e78a62 to
0bb91c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes old code related to the geometry dictionary. This code is still evaluated but we don't use the data in the encoder.
This PR removes the dependency on Atlas in both the action and tool, and it removes the MARS key
represinFullMarsRecord.Note that it is now sufficient to set
gridortruncationin the MARS dictionary and the rest can be handled in the encoder.This change is needed to support ocean fields, their grids can't be handled by this removed code.
These changes are needed for this PR in the encoder: ecmwf/metkit#181
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-247