Fix handling of lat/lon grids in grib1-to-grib2 tool#254
Merged
Conversation
tweska
force-pushed
the
fix/lat-lon-grids
branch
from
84e428e to
6d0959c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #254 +/- ##
===========================================
- Coverage 56.32% 56.31% -0.02%
===========================================
Files 321 321
Lines 21152 21159 +7
Branches 1680 1681 +1
===========================================
+ Hits 11914 11915 +1
- Misses 9238 9244 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dsarmany
requested changes
Mar 27, 2026
Collaborator
dsarmany
left a comment
dsarmany
left a comment
There was a problem hiding this comment.
Check my comment. I may miss something, but I am unsure what happens in the else branch.
dsarmany
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lat/lon grids don't have
gridNameand thus we couldn't generate the MARSgridkeyword anymore. This PR checks thegridTypekey first for special handling, before falling back togridName.🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-254