Skip to content

Fix passing through misc keys in encode-mtg2#275

Merged
dsarmany merged 1 commit into
developfrom
hotfix/encode-mtg2-misc-passthrough
May 19, 2026
Merged

Fix passing through misc keys in encode-mtg2#275
dsarmany merged 1 commit into
developfrom
hotfix/encode-mtg2-misc-passthrough

Conversation

@pgeier
Copy link
Copy Markdown
Contributor

@pgeier pgeier commented May 13, 2026

Description

All keys with "misc-" prefix never made it properly to the mars2grib.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-275

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.21%. Comparing base (d3e61e9) to head (7d9b19a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #275      +/-   ##
===========================================
- Coverage    33.21%   33.21%   -0.01%     
===========================================
  Files          374      374              
  Lines        41063    41061       -2     
  Branches      1701     1703       +2     
===========================================
- Hits         13638    13637       -1     
+ Misses       27425    27424       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes forwarding of misc-* metadata from MultIO’s encode-mtg2 action into metkit’s mars2grib encoder by dumping the misc record without its misc- key prefix, ensuring those keys are interpreted correctly by mars2grib.

Changes:

  • Switch misc configuration generation from dumpRecord(...) to dumpUnscopedRecord(...) so misc-* keys arrive at mars2grib with the expected key names.
  • Remove unused (mapped) mars/misc LocalConfiguration dumps in executeImpl.
  • Remove a stale TODO related to writing mapped metadata into the output message header.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/multio/action/encode-mtg2/EncodeMtg2.cc
Comment thread src/multio/action/encode-mtg2/EncodeMtg2.cc
@dsarmany dsarmany merged commit 24280e1 into develop May 19, 2026
571 of 583 checks passed
@dsarmany dsarmany deleted the hotfix/encode-mtg2-misc-passthrough branch May 19, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants