Bugfix/host variables#91
Merged
Merged
Conversation
… it by the update_node_attributes method
jinmannwong
reviewed
Aug 13, 2025
| # Update the options with host-specific attributes | ||
| for attribute, values in host_attrs.items(): | ||
| if attribute in ["variables"]: | ||
| variables = options.pop("variables", {}) |
Contributor
There was a problem hiding this comment.
Could we change "variables" to attribute? Just so it works if we add additional attributes into host_attrs. Similar change needed for "generated_variables" below.
jinmannwong
approved these changes
Aug 13, 2025
Contributor
jinmannwong
left a comment
jinmannwong
left a comment
There was a problem hiding this comment.
One small comment, otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing ecflow_variables from host and replacing it by a function that updates a node attributes.
Contributor Declaration
By opening this pull request, I affirm the following: