Conversation
Cleaner code in util
plainheart
reviewed
Oct 15, 2021
Ovilia
approved these changes
Oct 15, 2021
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature introduces new
setPlatformAPImethod to provide the ability to extend platform-dependent methods.When we using SSR mode in #836. There is still an issue that hasn't been solved. If we use a customized font, which glyph is very different from the default font. There is no built-in method for NodeJS or echarts to get text width accurately. In this case, we still need to rely on the third-party library like
node-canvasto measure text. The original methodzrender.util.$override('createCanvas', () => ...)looks very internal.So in this PR we abstract a new concept
platformthat can provide these platform-dependent methods. Currently there are three methods.createCanvas
Same with the original
zrender.util.createCanvas. With this, you can usenode-canvasor some other canvas like API in NodeJS.measureText.
If you have a more lightweight text measurement implementation. You can only extend this method. It's not required if you have registered
createCanvasand canvas implementation already havemeasureTextmethod.loadImage
If you are using
node-canvasor some other canvas like API and wan't draw images. This will be required.Or in SSR mode. Only image width/height is needed. We can provide a more lightweight method.