forked from mozilla-mobile/firefox-ios
-
Notifications
You must be signed in to change notification settings - Fork 9
[MOB-3897] Welcome screen for product tour #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucaschifino
wants to merge
34
commits into
ls-mob-3544-onboarding-product-tour
Choose a base branch
from
ls-mob-3897-welcome-screen
base: ls-mob-3544-onboarding-product-tour
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
3949480
[MOB-3897] Create WelcomeView using SwiftUI and replace old Welcome
lucaschifino 550351c
[MOB-3897] Cleanup WelcomeTour classes and assets
lucaschifino c01626c
[MOB-3897] Fix video player
lucaschifino c971a30
[MOB-3897] Animated transition from Launch Screen
lucaschifino 549ee31
[MOB-3897] Add some todos
lucaschifino 4474e82
[MOB-3897] Implement exit animation
lucaschifino 33e7909
[MOB-3897] Animate browser toolbars after welcome screen
lucaschifino 222f6f0
[MOB-3897] Adjust logo color and animation
lucaschifino 6f6a402
[MOB-3897] Adjust video frame
lucaschifino cd2f98a
[MOB-3897] Simplify unnecessary extension
lucaschifino 3270934
[MOB-3897] Add experiment unleash flag
lucaschifino f70e941
[MOB-3897] Add fade transition to welcome screen
lucaschifino 57a1291
[MOB-3897] Adjust toolbars animation
lucaschifino 69042be
[MOB-3897] Add analytics events
lucaschifino 6831184
[MOB-3897] Make sure onboarding gets presented on iPad
lucaschifino ac612cd
[MOB-3897] Adjust spacings and offsets
lucaschifino 90ed778
[MOB-3897] Use dynamic welcome text height
lucaschifino 10c62d7
[MOB-3897] Adjust top offset on iPad
lucaschifino 2586618
[MOB-3897] Add line break and adjust margin
lucaschifino bb336fe
[MOB-3897] Match NTP background on fade transition dismissal
lucaschifino 460d88a
[MOB-3897] Make sure initial logo matches launch screen
lucaschifino 09c7dd3
[MOB-3897] Add gradients behind content for visibility
lucaschifino 6f638a9
[MOB-3897] Fix fade transition
lucaschifino 77597e3
[MOB-3897] Move video player to separate file
lucaschifino ccb93f2
[MOB-3897] Wait for video to be ready and support reduced motion
lucaschifino bb1618f
[MOB-3897] Use Task instead of Dispatch
lucaschifino 9798e4a
[MOB-3897] Fix AnalyticsSpyTests
lucaschifino a2df0be
[MOB-3897] Add text strings
lucaschifino 3cb6198
[MOB-3897] Handle retriggering onAppear
lucaschifino ccddf74
[MOB-3897] Fix tests mock
lucaschifino 47d5dee
[MOB-3897] Remove spy tests for now
lucaschifino 68fd500
[MOB-3897] Add Ecosia comments
lucaschifino 93c6dd7
[MOB-3897] Wait for feature flags before presenting welcome screen
lucaschifino c18d321
[MOB-3897] [MOB-3903] Do not show APN consent during experiment
lucaschifino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // This Source Code Form is subject to the terms of the Mozilla Public | ||
| // License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| // file, You can obtain one at http://mozilla.org/MPL/2.0/ | ||
|
|
||
| import Foundation | ||
|
|
||
| extension Task where Success == Never, Failure == Never { | ||
| /// Sleep for a given duration in seconds, with iOS 15 compatibility | ||
| /// When iOS 16+ becomes minimum, this can be replaced with Task.sleep(for: .seconds()) | ||
| static func sleep(duration: TimeInterval) async throws { | ||
| if #available(iOS 16.0, *) { | ||
| try await Task.sleep(for: .seconds(duration)) | ||
| } else { | ||
| try await Task.sleep(nanoseconds: UInt64(duration * 1_000_000_000)) | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 0 additions & 20 deletions
20
firefox-ios/Client/Ecosia/UI/Ecosia.xcassets/onboardingWaves.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-1.09 KB
firefox-ios/Client/Ecosia/UI/Ecosia.xcassets/onboardingWaves.imageset/onboardingWaves.pdf
Binary file not shown.
Binary file removed
BIN
-1.09 KB
...ox-ios/Client/Ecosia/UI/Ecosia.xcassets/onboardingWaves.imageset/onboardingWaves_iPad.pdf
Binary file not shown.
6 changes: 0 additions & 6 deletions
6
firefox-ios/Client/Ecosia/UI/Ecosia.xcassets/tour/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-1.69 MB
firefox-ios/Client/Ecosia/UI/Ecosia.xcassets/tour/tour1.imageset/1 51.png
Binary file not shown.
Binary file removed
BIN
-3.64 MB
firefox-ios/Client/Ecosia/UI/Ecosia.xcassets/tour/tour1.imageset/1 52.png
Binary file not shown.
Binary file removed
BIN
-6.23 MB
firefox-ios/Client/Ecosia/UI/Ecosia.xcassets/tour/tour1.imageset/1 53.png
Binary file not shown.
31 changes: 0 additions & 31 deletions
31
firefox-ios/Client/Ecosia/UI/Ecosia.xcassets/tour/tour1.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
30 changes: 0 additions & 30 deletions
30
firefox-ios/Client/Ecosia/UI/Ecosia.xcassets/tour/tour2.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-1 MB
firefox-ios/Client/Ecosia/UI/Ecosia.xcassets/tour/tour2.imageset/Group 1434.jpg
Binary file not shown.
Binary file removed
BIN
-3.14 MB
firefox-ios/Client/Ecosia/UI/Ecosia.xcassets/tour/tour2.imageset/Group 1435.jpg
Binary file not shown.
15 changes: 0 additions & 15 deletions
15
firefox-ios/Client/Ecosia/UI/Ecosia.xcassets/tour/tour3.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-1.22 MB
firefox-ios/Client/Ecosia/UI/Ecosia.xcassets/tour/tour3.imageset/MAP.pdf
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we move this into our Ecosia framework?