cache type descriptors and media types#145
Merged
dgafka merged 2 commits intoecotoneframework:mainfrom Jun 9, 2023
Merged
Conversation
dgafka
reviewed
Jun 9, 2023
|
|
||
| private const TYPE_PARAMETER = 'type'; | ||
|
|
||
| private static array $parsedMediaTypes = []; |
Member
There was a problem hiding this comment.
Is using enum having the same effect or enums are always new instances?
Contributor
Author
There was a problem hiding this comment.
How would you use enum in this case ?
The goal is mainly to avoid parsing the media type again and again, as it is called a lot of times for a single message
Member
|
That benchmark did the job. I could clearly see how huge impact this PR has. On average it's around 15% boost 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.