fix(xr): disable post-processing while presenting#174
Merged
Conversation
EffectComposer (N8AO + Vignette) renders to an offscreen target and blits to the canvas — that path doesn't write into the XR layer's framebuffer, so during a WebXR session the scene goes black and only objects rendered directly by WebXRManager (hands, controllers) show. That's the "all black except your hands" symptom in immersive-vr. Skip the EffectComposer when `xrPresenting` is true. Outside XR the post-processing is unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EffectComposer(N8AO + Vignette) renders to an offscreen target and blits to the canvas. That blit doesn't write into the WebXR layer's framebuffer, so during animmersive-vr/immersive-arsession the scene goes black and only objects rendered directly byWebXRManager(hands, controllers) appear.This PR skips the
EffectComposerblocks in ViewportContent.tsx whenxrPresentingis true. Outside XR the post-processing is unchanged.Why
Reported symptom from a real headset right after #173 landed: "when you enter VR, it's just all black except for your hands." That's the textbook signature of an offscreen-target post-processing pipeline running over the XR framebuffer.
Test plan