Level 1 layout #52
Merged
Level 1 layout #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ectodrop
commented
Feb 27, 2024
ectodrop
commented
- Redesign level 1 layout
- Add sound effects
- Change the lighting system to use lightmaps and light probes for better looking lighting
- added some placeholder office assets
changed level 1 layout baked lighting placeholder assets to dress the scene
wang-henry
approved these changes
Feb 27, 2024
Collaborator
wang-henry
left a comment
wang-henry
left a comment
There was a problem hiding this comment.
Code looks good to me.
| public GameEvent powerOff; | ||
|
|
||
| private readonly int _defaultIntensity = 50; | ||
| // private readonly int _defaultIntensity = 50; |
| public Material lightOn; | ||
| public Material lightOff; | ||
|
|
||
| private LightmapData[] darkLightMap, brightLightmap; |
Collaborator
There was a problem hiding this comment.
Suggested change
| private LightmapData[] darkLightMap, brightLightmap; | |
| private LightmapData[] _darkLightMap, _brightLightmap; |
just to keep things consistent
Co-authored-by: Henry Wang <32380663+wang-henry@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.