fix(engine): exit non-zero on a masked set -u crash#52
Merged
Conversation
The EXIT trap (on_exit) inherited the script's $?, so any abort that left $?==0 made a crashed run exit 0 — green to the docker wrapper, CI, and humans. The masking class is a `set -u` fatal expansion (unbound scalar or empty-array) on macOS's stock Bash 3.2, which enters the trap with $?==0; this is what let the broken first cut of the #41 fix read as green. Derive the exit code from the explicit OUTCOME signal instead of $?: a propagated failure (set -e / exit N / 127 / INT-TERM re-exits) keeps its code, otherwise only a run that reached OUTCOME=green may exit 0. Add a regression test that drives the exact trap state ($?==0 with OUTCOME never green) deterministically and cross-version — Bash 5.x leaves $?==1 on a real set -u abort, so the test aborts the engine mid-gate with a parent `exit 0` instead and asserts a non-zero exit with no green DONE banner.
This was referenced May 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45. The EXIT trap inherited the script exit status, so a set-u abort (which enters the trap with status 0 on macOS Bash 3.2) made a crashed run exit 0 — green to the docker wrapper, CI, and humans. The exit code now derives from the explicit OUTCOME signal: a propagated failure keeps its code; only a run that reached OUTCOME=green may exit 0. Adds a cross-version bats regression. Built by feature-loop (green, iteration 1); the Co-Authored-By trailer was stripped pre-push.