feat(engine): suppress commit/PR attribution by default, add FL_COMMIT_ATTRIBUTION opt-out#54
Merged
Merged
Conversation
…T_ATTRIBUTION opt-out
The in-container agent ran with Claude Code defaults, so every commit it authored
carried a Co-Authored-By: Claude / "Generated with Claude Code" trailer, violating
the project's no-AI-attribution convention. The host ~/.claude is intentionally never
mounted, so the convention never reached the container.
Pass the suppression on every claude call via the --settings flag, which outranks all
settings.json scopes but "managed" — so it holds regardless of the base image, with no
filesystem side effects. Both keys are set (includeCoAuthoredBy + attribution.{commit,pr})
as belt-and-suspenders against the deprecation. FL_COMMIT_ATTRIBUTION=1 (env or
.featureloop) omits the flag, restoring Claude Code's default trailer.
Covered by three bats tests: default suppression, env opt-out, and .featureloop opt-out.
Add the knob to the .featureloop config reference and the example config, set it explicitly in this repo's own dogfood config, and record Added/Fixed notes in the changelog (semver minor: new opt-out surface plus the suppressed-trailer fix).
ecukalla
force-pushed
the
feature/ISSUE-50-commit-attribution
branch
from
fa7ad1c to
926653f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50. The in-container agent ran with Claude Code defaults, so commits it authored carried a Co-Authored-By / Generated-with-Claude-Code trailer — violating the no-AI-attribution rule (the host ~/.claude is intentionally never mounted). This passes the suppression on every claude call via --settings (sets includeCoAuthoredBy + attribution.{commit,pr}; outranks settings.json scopes, no filesystem side effects, works on any base image). FL_COMMIT_ATTRIBUTION=1 (env or .featureloop) opts back in. Adds 3 bats tests (default, env opt-out, .featureloop opt-out) + docs + CHANGELOG. Once merged + released, future feature-loop runs won't need manual trailer-stripping. Built by feature-loop (green, iteration 1).