Implement fnmatch for wildcard column selection#154
Merged
tomreitz merged 1 commit intoApr 18, 2025
Merged
Conversation
pjsharpe07
commented
Mar 26, 2025
| else: | ||
| self.apply_jinja(data, col, val) | ||
| # Use the fnmatch column functionality to find each valid value | ||
| for data_column in data.columns: |
Author
There was a problem hiding this comment.
Let me know if this approach is on the right track!
The naming convention here may need tweaking. This also allows for sequential matches to also occur ie more than one modification can happen on the same column. Unclear if that is intended behavior.
Collaborator
|
Hi @pjsharpe07 thanks so much for this contribution! Our team took a look and we like this approach. I'm going to merge your fork into a branch and make a few changes:
We'll credit you when it gets merged to |
tomreitz
changed the base branch from
main
to
feature/wildcard_matching_for_columns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking to implement the changes mentioned in issue #116
Currently this is only implemented in
ModifyColumnsOperation- leaving as a draft to ensure this is the correct path to take.