Student academic records - fix ordering #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlittle08
requested changes
Dec 15, 2023
models/staging/edfi_3/stage/stg_ef3__student_academic_records.sql
Outdated
Show resolved
Hide resolved
ejoranlienea
approved these changes
Dec 20, 2023
ejoranlienea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
The student academic record models currently include
k_studentonly, which excludes any historical records from years prior to the earliestdim_studentrecords. This PR addsk_student_xyearand corrects the dedupe ordering logic to keep records from the post recent api_year.Changes to existing files:
_edfi_3__stage.yml: remove k_student ref teststg_ef3__student_academic_records: addk_student_xyear; correct ordering logic; remove redundant field in the partitionTests and QC done (together with edu_wh):
PR Merge Priority:
Low - note that this edu_wh PR depends on it