Staff Email Handling#179
Merged
Merged
Conversation
rlittle08
reviewed
Jul 18, 2025
Collaborator
|
one comment on regex^ otherwise ready to merge & release |
want literal characters _.-, not the range between . and _. reordering avoids interpreting - as a range indicator without escapes also pin to start and end of string
rlittle08
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation
This adds two primary features:
First, Ed-Fi introduced
StaffEducationOrganizationContactAssociation, which provides a second possible place to put email addresses (in addition tostaffsitself). This PR adds a build model that combines emails from the two sources into one unified list.
Second, it also adds a second build model on top of this that attempts to filter this down to only official/work emails, which can be useful for syncing to authentication/authorization systems, or other use-cases that require only valid, official email addresses. It does this by applying 3 filters:
Breaking changes introduced by this PR:
PR Merge Priority:
Changes to existing files:
New files created:
Tests and QC done:
edu_wh PR Review Checklist:
Make sure the following have been completed before approving this PR:
## New Featuresfor features, etc.