Skip to content

Staff Email Handling#179

Merged
rlittle08 merged 6 commits into
mainfrom
experiment/staff_email_handling
Jul 18, 2025
Merged

Staff Email Handling#179
rlittle08 merged 6 commits into
mainfrom
experiment/staff_email_handling

Conversation

@ejoranlienea
Copy link
Copy Markdown
Contributor

Description & motivation

This adds two primary features:

First, Ed-Fi introduced StaffEducationOrganizationContactAssociation, which provides a second possible place to put email addresses (in addition to staffs itself). This PR adds a build model that combines emails from the two sources into one unified list
.
Second, it also adds a second build model on top of this that attempts to filter this down to only official/work emails, which can be useful for syncing to authentication/authorization systems, or other use-cases that require only valid, official email addresses. It does this by applying 3 filters:

  1. Check whether the email address is structurally valid
  2. Filter to email addresses tagged with a descriptor that indicates official/work email (configurable)
  3. In case of data entry errors, also attempt to remove emails from personal-looking domains (also configurable).

Breaking changes introduced by this PR:

PR Merge Priority:

  • Low
  • Medium
  • High

Changes to existing files:

New files created:

Tests and QC done:

edu_wh PR Review Checklist:

Make sure the following have been completed before approving this PR:

  • Description of changes has been added to Unreleased section of CHANGELOG.md. Add under ## New Features for features, etc.
  • If a new configuration xwalk was added:
    • The code is written such that the xwalk is optional (preferred), and this behavior was tested, OR
    • The code is written such that the xwalk is required, and the required xwalk is added to edu_project_template, and this PR is flagged as breaking change (not for patch release)
    • A description for the new xwalk has been added to EDU documentation site here
  • If a new configuration variable was added:
    • The code is written such that the variable is optional (preferred), and this behavior was tested, OR
    • The code is written such that the variable is required, and a default value was added to edu_project_template, and this PR is flagged as breaking change (not for patch release)
    • A description for the new variable has been added to EDU documentation site here
  • Reviewer confirms the grain of all tables are unchanged, OR any changes are expected, communicated, and this PR is flagged as a breaking change (not for patch release)

Comment thread models/build/edfi_3/staffs/bld_ef3__staff_emails.sql Outdated
@rlittle08
Copy link
Copy Markdown
Collaborator

one comment on regex^ otherwise ready to merge & release

ejoranlienea and others added 4 commits July 18, 2025 10:45
want literal characters _.-, not the range between . and _. reordering
avoids interpreting - as a range indicator without escapes
also pin to start and end of string
@rlittle08 rlittle08 merged commit 6e7e836 into main Jul 18, 2025
@rlittle08 rlittle08 deleted the experiment/staff_email_handling branch July 18, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants