Fix: Executor should not send unmatched students file when Earthmover fails#63
Open
johncmerfeld wants to merge 2 commits into
Open
Fix: Executor should not send unmatched students file when Earthmover fails#63johncmerfeld wants to merge 2 commits into
johncmerfeld wants to merge 2 commits into
Conversation
…er run When Earthmover crashes mid-pipeline it may still have produced match_rates.csv and input_no_student_id_match.csv on disk. The except branch in execute() would then upload both via upload_remaining_artifacts, surfacing partial results to the user that don't reflect what actually happened. The original decision (recovered from prior discussion) was that on any fatal EM run we don't care about either file. Make the rule explicit by clearing needs_upload on both artifacts inside _run_earthmover's finally when fatal, before raising. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long ago a decision was made to show the user unmatched students even when Earthmover fails
This can happen when the file is pretty-good-but-still-wrong. We now recognize that this is buggy behavior because the file we give back to the user to fix will almost certainly fail when they re-upload it, plus we've filtered out the students that actually matched the first time but still weren't uploaded.