Workspace Factory #4: Category Color

[edauterman]

The user can now pick a color for their category given a choice of colors. The user chooses colors through the Closure PopupColorPicker, which is initialized with Blockly specific colors, and their choice of colors shows up as a left border on the category tab in the view (to look similar to the Blockly toolbox UI).

Also made the few small changes suggested by picklesrus and vicng in the last CL.

---

This change is

[edauterman]

+@picklesrus +@vicng +@quachtina96

---

Review status: 0 of 6 files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[picklesrus]

---

Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion.

---

demos/workspacefactory/index.html, line 510 [r2] (raw file):

  goog.events.listen(popupPicker, 'change', function(e) {
        controller.changeColor(popupPicker.getSelectedColor());
      });

I think indentation is off here.

---

Comments from Reviewable

[vicng]

---

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions.

---

demos/workspacefactory/factory_controller.js, line 344 [r2] (raw file):

 * a valid CSS string.
 */
FactoryController.prototype.changeColor = function(color) {

Nit: Rename changeSelectedCategoryColor

I think changeColor is a bit too vague since this controller is basically the only entry point that the app is talking to.

---

Comments from Reviewable

[edauterman]

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions.

---

demos/workspacefactory/factory_controller.js, line 344 [r2] (raw file):

Previously, vicng wrote…

Nit: Rename changeSelectedCategoryColor

I think changeColor is a bit too vague since this controller is basically the only entry point that the app is talking to.

Changed.

---

demos/workspacefactory/index.html, line 510 [r2] (raw file):

Previously, picklesrus wrote…

I think indentation is off here.

We talked about this and no changes necessary.

---

Comments from Reviewable