Setting config before the TextEditorWidget is created

[distractor]

I see the default theme is set to Monokai in this line.

This is somewhat of a problem if I don't have the Monokai.tmTheme file, nor do I want to use it. The problem is that as soon as TextEditorWidget is created

edbee::Edbee::instance()->setThemePath(":/resources/edbee/themes");  // Enables to set theme by name.
m_pEditor = new edbee::TextEditorWidget();
m_pEditor->setMinimumHeight(200);

an error message is logged:

"texttheme.cpp" @ 424 "Error theme not found :/resources/edbee/themes/Monokai.tmTheme."

This is understandable, since the Monokai.tmTheme is not even there, but I want it to start with a different theme, i.e. different config.

Question

Can I set the config (in particular the theme) beforehand, so that this error message would not get logged for users that don't want to use Monokai? Is that an option?

[gamecreature]

I'm checking out this problem. You're completely right the config is used before you can change it.

A possible solution could be the possibility to supply a TextEditorConfig object the constructor of the widget. This is something that needs to be built in edbee.

[distractor]

@gamecreature I just created a pull request with my changes to make this work. My idea was to create the TextEditorWidget with the config as an argument:

edbee::Edbee::instance()->setThemePath(":/resources/edbee/themes");  // Enables to set theme by name.
    
edbee::TextEditorConfig* config = new edbee::TextEditorConfig();
config->setThemeName("MyCustomThemeName");

m_pEditor = new edbee::TextEditorWidget(nullptr, config); 

This (in theory) fixed it, but I am not sure how well it fits into current design as I am a fairly new EdBee user. Nonetheless, it might be of use to you. I wouldn't know. :)

Feel free to just discard it if you find it useless.

[distractor]

Hi @gamecreature ,

We broke something with this PR #156

Previously I could run

    edbee::Edbee::instance()->setThemePath(":/resources/edbee/themes");  // Enables to set theme by name.
    m_pEditor = new edbee::TextEditorWidget();
    m_pEditor->setMinimumHeight(200);

    // Connect the textChanged signal from the TextDocument to the slot that emits codeChanged.
    connect(m_pEditor->textDocument(), &edbee::TextDocument::textChanged, this, &SourceEditor::onTextChanged);

    // Set layout.
    QVBoxLayout* pLayout = new QVBoxLayout(this);
    pLayout->setContentsMargins(0, 0, 0, 0);
    pLayout->addWidget(m_pEditor);

And this used to work.

After pulling the latest master (v0.11.0), the run ends with a fatal error:

FATAL ERROR: ASSERT: "inited_" in file /home/whatever-the-path/edbee-lib/edbee-lib/edbee/edbee.cpp, line 264

The fatal error can be avoided with an additional call of edbee::Edbee::instance()->autoInit(); prior to the rest of the code above, but the Grammar is still somehow broken/not working.

Can you confirm this or is it just me?

[gamecreature]

I can confirm this is happening!
Thanks for noticing this.

I fixed it by moving the autoInit to the creation of the CharTextDocument.

Btw. I've also noticed I released an incorrect versioned edbee. (Version number was still uncommitted in my local Repository 🫤).

So I'm going to release a new version 0.11.1.

[distractor]

Thank you for your quick response. After my (short) testing, this appears to be fixed now with the v0.11.1.

Thus, I'm closing the issue.