Skip to content

Revise: fix QString::split(...) for older Qt Versions#113

Merged
gamecreature merged 1 commit intoedbee:masterfrom
SlySven:Revise_fixQStringSplitForOlderQtVersions
Oct 27, 2020
Merged

Revise: fix QString::split(...) for older Qt Versions#113
gamecreature merged 1 commit intoedbee:masterfrom
SlySven:Revise_fixQStringSplitForOlderQtVersions

Conversation

@SlySven
Copy link
Copy Markdown
Contributor

@SlySven SlySven commented Oct 27, 2020

A use of the above in the test code fails to build on anything older than Qt 5.14 as the enum used is only present in that and newer versions. Previously the enum was a member of the QString class rather than the Qt namespace...

Signed-off-by: Stephen Lyons slysven@virginmedia.com

@SlySven
Revise: fix QString::split(...) for older Qt Versions
56343e5 
A use of the above in the test code fails to build on anything older than
Qt 5.14 as the `enum` used is only present in that and newer versions.
Previously the `enum` was a member of the `QString` class rather than the
`Qt` namespace...

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
@SlySven
Copy link
Copy Markdown
Contributor Author

SlySven commented Oct 27, 2020 •
edited
Loading

For some reason the CI tests (that the Mudlet team inserted into the code base in 47f970c) on Linux run against Qt 5.6 (it seems) so are thus borked currently...

@SlySven
Copy link
Copy Markdown
Contributor Author

SlySven commented Oct 27, 2020

@gamecreature What is the minimum Qt version that you intend (or would like) the edbee-lib library to compile with?

@gamecreature
Copy link
Copy Markdown
Member

gamecreature commented Oct 27, 2020 •
edited
Loading

Thank you!!
I don't have a special wish for what the minimum version is. I will adjust for Mudlet if required... (Though I don't have the time to test every version)
The only requirement I have is that it will run on the latest Qt..
So If you've got issues with Mudlet please let me know, and we can add workarounds like the one above!

@gamecreature gamecreature merged commit 5dbc329 into edbee:master Oct 27, 2020
@SlySven
Copy link
Copy Markdown
Contributor Author

SlySven commented Oct 27, 2020

I don't have a special wish for what the minimum version is.

Well, it might be worth coding to at lest consider the oldest current LTS version (currently that is QT 5.12.8 IIRC with an EOL 2020/12/05)... https://en.wikipedia.org/wiki/Qt_version_history#Qt_5 is probably worth bookmarking...

@gamecreature
Copy link
Copy Markdown
Member

gamecreature commented Dec 3, 2020

@SlySven I agree on this. I think LTS is a good lowest version to aim for. (Sorry for the late response).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SlySven @gamecreature