Fix remove some depreciation warnings for qt6 and other warnings and spelling errors#138
Merged
gamecreature merged 6 commits intoedbee:masterfrom Mar 21, 2023
Conversation
Otherwise for some combinations of MACROs one ends up with "unreachable code" or "unused variables"! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
The suggested replacement is std::unique_ptr<T> ... Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
al ==> a or all agains ==> against alread ==> already argumens ==> arguments aroudn ==> around automaticly ==> automatically betrer ==> better callibirates ==> calibrates carrets ==> carets Chagned ==> Changed componenents ==> components compnents ==>components confirguation ==> configuration controlelr ==> controller controlle ==> controller digets ==> digits emition ==> emission functiona ==> function happend ==> happen invaldating ==> invalidating manger ==> manager mediater ==> mediator mehtod ==> method offeset ==> offset offest ==> offset pallette ==> palette reangeSet ==> rangeSet recieve ==> receive recieving ==> receiving renderes ==> renders Rreturns ==> Returns Returnst ==> Returns returnst ==> returns scolling ==> scrolling seperate ==> separate Setst ==> Sets suppplying ==> supplying supprort ==> support hte ==> the tranfers ==> transfers transfered ==> transferred Tripple ==> Triple truely ==> truly vible ==> visible wordt ==> word Uou ==> You Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
vadi2
approved these changes
Mar 20, 2023
Member
|
@SlySven This looks very good!! Thank you! |
Member
|
@SlySven Just run compiled and run qt5 and qt6 versions on Mac OS X. (app + tests still work) Everything looks good! |
SlySven
deleted the
Fix_removeSomeDepreciationWarningsForQt6AndOtherWarningsAndSpellingErrors
branch
SlySven
added a commit
to Mudlet/Mudlet
that referenced
this pull request
Mar 23, 2023
This pulls in my changes to edbee-lib to remove some warnings associated with using Qt6 (and also fixes some spelling errors and other warnings). See edbee/edbee-lib#138 for the details. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gamecreature I've been working on getting Mudlet to build in a Qt 6 environment and found a few things that I think need fixing to work. As such I've put together a number of commits which address different things that were producing warnings when built against Qt 6.4.1 on Linux (and one or two things that also do so in Qt 5.15.2). I suspect you might want to examine and, hopefully, cherry-pick each of these commits in order rather than just merging the whole lot in one swell foop. Anyhow I hope they are of use...