fix: allow to override h1 to h6 through discovered components#2
Conversation
Fixes: edge-js#1 Signed-off-by: Xavier Stouder <xavier@stouder.io>
|
The issue is, what if the filename on the disk is saved as camelCase or PascalCase? |
|
Thanks for your answer. I usually avoid camelCase/PascalCase filenames, so I hadn't considered that case. |
|
Yeah, our string utilities are bad with converting properties that contains numbers or dots. So we can be selective about html elements with numbers like headings |
|
I handle titles as specific cases, I didn't find any other html tag that uses number and I could have missed something, but I guess it won't be relevant anyway regarding markdown override. Let me know if something more is required, thanks for the review! |
|
👍🏽 |
🔗 Linked issue
#1
❓ Type of change
📚 Description
dashCase is not what's needed there, we just want to replace
_with-as-is. Let me know if you'd prefer an other way to allow package users to overrideh2node by loadingh2.edgecomponent. Without the change, dash casing loadh2.edgeash-2, meaning it will never be used to replace## titlein markdown.📝 Checklist