Proper SQL identifier parameterization in PostgreSQL loader#53
Open
Proper SQL identifier parameterization in PostgreSQL loader#53
Conversation
Replace f-string interpolation of table and column names with psycopg2.sql.Identifier across all SQL construction sites in the PostgreSQL loader. This is the driver's own escaping logic and handles reserved keywords and special characters correctly. Also switches COPY from copy_from to copy_expert, which allows quoting both table and column identifiers via sql.SQL.
fordN
changed the title
fordN
changed the title
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the concern raised by Aikido in #48 (SQL identifier concatenation) properly, and also covers the column quoting gap tracked in #52. Rather than a one-off regex validation, this uses psycopg2's built-in
sqlmodule which handles reserved keywords, schema-qualified names, and special characters correctly.Changes
psycopg2.sql.Identifiercopy_fromtocopy_expertso both table and column identifiers can beproperly quoted
Closes #52