refactor(dataset-store): use HashReference as cache key
#1547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undo the premature optimization of using only the Hash to deduplicate datasets in the dataset-store cache. This enables future simplifications in the data plane (query engine, data store). - Change `Dataset.manifest_hash` field to `Dataset.reference` (HashReference) - Update dataset cache from `HashMap<Hash, Dataset>` to `HashMap<HashReference, Dataset>` - Update eth_call cache to also use `HashReference` as key - Update all extractors to receive `HashReference` in `dataset()` functions - Simplify tracing statements to use `reference.short_display()` Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undo the premature optimization of using only the
Hashto deduplicate datasets in the dataset-store cache. This enables future simplifications in the data plane (query engine, data store).Dataset.manifest_hashfield toDataset.reference(HashReference)HashMap<Hash, Dataset>toHashMap<HashReference, Dataset>HashReferenceas keyHashReferenceindataset()functionsreference.short_display()