fix: remove eth-beacon extractor #1594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theodus
force-pushed
the
theodus/segment-prev-hash
branch
from
b57b804 to
7838dd9
Compare
Theodus
force-pushed
the
theodus/segment-prev-hash
branch
from
7838dd9 to
3c23e17
Compare
Theodus
force-pushed
the
theodus/segment-prev-hash
branch
from
6cc3102 to
780ac3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extractor does not handle some edge-cases present in the Beacon chain. But more importantly, it relies on the
BlockRange::prev_hashfield being optional, which we need to rethink before implementing any extractor or non-blockchain dataset.