refactor(datasets-common): rename RawDatasetKind to DatasetKindStr
#1634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid terminology collision with Raw Datasets, which are a distinct concept in the data model hierarchy (Raw vs Derived datasets). - Rename `RawDatasetKind` to `DatasetKindStr` across all crates - Rename module from `raw_dataset_kind.rs` to `dataset_kind_str.rs` - Update doc comments to reference new type name - Clarify that this type represents a type-erased dataset kind identifier Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
fubhy
approved these changes
Jan 27, 2026
LNSD
deleted the
lnsd/refactor-datasets-common-rename-dataset-kind-str
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid terminology collision with Raw Datasets, which are a distinct concept in the data model hierarchy (Raw vs Derived datasets).
RawDatasetKindtoDatasetKindStracross all cratesraw_dataset_kind.rstodataset_kind_str.rs