eat(common): replace eager logical catalog with lazy async resolution#1849
Open
eat(common): replace eager logical catalog with lazy async resolution#1849
Conversation
LNSD
force-pushed
the
lnsd/feat-common-amp-async-catalog
branch
from
d85dd84 to
e6efa27
Compare
LNSD
changed the title
LNSD
force-pushed
the
lnsd/feat-common-amp-async-catalog
branch
13 times, most recently
from
7037315 to
b195c35
Compare
LNSD
force-pushed
the
lnsd/feat-common-amp-async-catalog
branch
4 times, most recently
from
3260ab9 to
4a2a1c8
Compare
Replace direct catalog network collection with BFS traversal of dataset dependencies to find raw datasets, enabling correct resolution for derived datasets. - Add `resolve_network_from_dependencies()` BFS function and `ResolveNetworkError` type - Replace `SpawnError::MultiNetwork` with `SpawnError::ResolveNetwork` wrapping the new error - Remove per-table network collection in admin-api schema handler - Add dummy network placeholder in schema endpoint for TS manifest builder compat Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/feat-common-amp-async-catalog
branch
2 times, most recently
from
bd7c5bf to
b448334
Compare
Shift dataset table and function resolution from upfront logical catalog construction to on-demand async schema providers, so only catalogs referenced by a SQL statement are resolved at planning time. - Add `AmpCatalogProvider` and `DatasetSchemaProvider` for lazy per-dataset table and function resolution through DataFusion's async catalog API - Introduce `SessionState` wrapper with SQL pre-resolution that extracts references from statements and resolves only matched async catalogs - Add `SelfSchemaProvider` for self-referencing virtual schema lookups - Delete `LogicalCatalog` and all four `catalog::logical` resolution modules (`for_query`, `for_dump`, `for_admin_api`, `for_manifest_validation`) Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/feat-common-amp-async-catalog
branch
from
b448334 to
1729202
Compare
LNSD
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shift dataset table and function resolution from upfront logical catalog construction to on-demand async schema providers, so only catalogs referenced by a SQL statement are resolved at planning time.
AmpCatalogProviderandDatasetSchemaProviderfor lazy per-dataset table and function resolution through DataFusion's async catalog APISessionStatewrapper with SQL pre-resolution that extracts references from statements and resolves only matched async catalogsSelfSchemaProviderfor self-referencing virtual schema lookupsLogicalCatalogand all fourcatalog::logicalresolution modules (for_query,for_dump,for_admin_api,for_manifest_validation)