refactor(common): add multi-network support to PhysicalTable#1968
Merged
refactor(common): add multi-network support to PhysicalTable#1968
Conversation
Derived tables will soon depend on raw datasets from multiple networks. Store resolved networks as BTreeSet<NetworkId> on PhysicalTable so downstream consumers have accurate network information. - Add `PhysicalTable.networks: BTreeSet<NetworkId>` populated at construction time; raw tables contribute a singleton, derived tables resolve from transitive dependencies - Extract `collect_raw_datasets` shared traversal in `datasets_cache` and rewrite `resolve_dataset_networks` and `resolve_raw_dataset_from_dependencies` on top of it - Resolve networks per-table at each `from_revision` call site, keeping `Table::network()` as the intrinsic single-network accessor - Update `find_cross_network_join` to compare `BTreeSet<NetworkId>` per table instead of a single optional network
Theodus
force-pushed
the
theodus/derived-dataset-networks
branch
from
76819ee to
2617d13
Compare
shiyasmohd
approved these changes
Mar 13, 2026
Contributor
shiyasmohd
left a comment
shiyasmohd
left a comment
There was a problem hiding this comment.
LGTM. Added some suggestion in comments.
| dataset.reference().clone(), | ||
| dataset.start_block(), | ||
| table_def.clone(), | ||
| table_def.network().into_iter().cloned().collect(), |
Contributor
There was a problem hiding this comment.
this could be an accessor method in Table trait, something like network_set() which can be used in a lot places.
Co-authored-by: Shiyas Mohammed <83513144+shiyasmohd@users.noreply.github.com> Signed-off-by: Theo Butler <theodusbutler@gmail.com>
Co-authored-by: Shiyas Mohammed <83513144+shiyasmohd@users.noreply.github.com> Signed-off-by: Theo Butler <theodusbutler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derived tables will soon depend on raw datasets from multiple networks. Store resolved networks as BTreeSet on PhysicalTable so downstream consumers have accurate network information.
PhysicalTable.networks: BTreeSet<NetworkId>populated at construction time; raw tables contribute a singleton, derived tables resolve from transitive dependenciescollect_raw_datasetsshared traversal indatasets_cacheand rewriteresolve_dataset_networksandresolve_raw_dataset_from_dependencieson top of itfrom_revisioncall site, keepingTable::network()as the intrinsic single-network accessorfind_cross_network_jointo compareBTreeSet<NetworkId>per table instead of a single optional network