Skip to content

refactor(admin-api): add cursor-based pagination to list revisions endpoint#1976

Merged
shiyasmohd merged 1 commit intomainfrom
shiyasmohd/cursor-list-revisions
Mar 16, 2026
Merged

refactor(admin-api): add cursor-based pagination to list revisions endpoint#1976
shiyasmohd merged 1 commit intomainfrom
shiyasmohd/cursor-list-revisions

Conversation

@shiyasmohd
Copy link
Contributor

  • Adds cursor-based pagination (last_id) to the GET /revisions endpoint and ampctl table list command, following the same pattern used by jobs::list
  • Merges the separate list (cursor-only) and list_all (active-filter-only) functions in physical_table_revision into a single list function that supports both cursor pagination and active filtering
  • Removes the now-redundant list_all and sql::list_all functions
  • Add tests

@shiyasmohd shiyasmohd self-assigned this Mar 14, 2026
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/cursor-list-revisions branch from 7da5ab6 to 7477c7f Compare March 14, 2026 10:55
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiyasmohd shiyasmohd merged commit 55b802b into main Mar 16, 2026
8 checks passed
@shiyasmohd shiyasmohd deleted the shiyasmohd/cursor-list-revisions branch March 16, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants