feat(worker): wire GC job type to worker and admin-api#2010
Merged
Conversation
Add GC job dispatch to the worker service so it can execute GC jobs when notified by the controller. Adds the Gc variant to JobDescriptor, JobError, and their trait impls. Adds From impl in admin-api scheduler for GC job descriptors, and display format in ampctl job list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gcvariant to the worker'sJobDescriptorenum so GC jobs can be deserialized and dispatchedjob_impl.rsthat builds aContextand callsamp_worker_gc::job_impl::execute()Gcvariant toJobErrorwithRetryableErrorExt,JobErrorExt, andErrorDetailsProvidertrait implsFrom<amp_worker_gc::job_descriptor::JobDescriptor>impl in admin-api schedulerampctl job listContext
This is PR 2 of 3 splitting up the GC job extraction work:
amp-worker-gccrate (merged in feat(amp-worker-gc): add standalone GC job crate #2009)