feat(admin-api): accept retry_strategy in job creation and deployment#2079
Merged
shiyasmohd merged 1 commit intomainfrom Apr 6, 2026
Merged
feat(admin-api): accept retry_strategy in job creation and deployment#2079shiyasmohd merged 1 commit intomainfrom
shiyasmohd merged 1 commit intomainfrom
Conversation
shiyasmohd
force-pushed
the
shiyasmohd/retry-strategy-admin-api
branch
from
aaac14f to
85d44f3
Compare
LNSD
requested changes
Apr 6, 2026
Contributor
LNSD
left a comment
LNSD
left a comment
There was a problem hiding this comment.
Please, check my comments 🙂
In general, if you see a validate() fn after deserialization, take it as a code smell.
shiyasmohd
force-pushed
the
shiyasmohd/retry-strategy-admin-api
branch
from
85d44f3 to
b726841
Compare
LNSD
approved these changes
Apr 6, 2026
| struct Descriptor<'a, D> { | ||
| kind: &'a str, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| retry_strategy: Option<RetryStrategy>, |
Contributor
There was a problem hiding this comment.
I would make this mandatory, no optional retry_strategy. I understand that for backward-compat, we need this, but we should require the retry policy and trigger to be present in the job ledger job details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RetryStrategy.