Conversation
LNSD
force-pushed
the
lnsd/refactor-extractors-align-manifest-types
branch
2 times, most recently
from
0c46666 to
74c44c2
Compare
…ractor crate patterns Brings firehose and substreams extractors in line with the patterns used by other dataset extractors for better consistency across the codebase. - Add standardized `dataset_kind.rs` modules to both crates - Update build scripts to match consistent code generation approach - Align module structures with evm-rpc and eth-beacon patterns Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/refactor-extractors-align-manifest-types
branch
from
74c44c2 to
2ec1f7e
Compare
LNSD
changed the title
LNSD
commented
Sep 29, 2025
Contributor
Author
There was a problem hiding this comment.
This file is marked as a move, but it is actually two things:
- Remove the leftover file in
common - Add a new
dataset_kindmodule to the firehose extractor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context and Rationale
This PR aligns the eth-beacon, firehose, and substreams dataset extractor crates with the patterns established by the other extractors and the derived datasets crate.
This is another #796 PR spinoff.
Commit message
Brings firehose and substreams extractors in line with the patterns used by other dataset extractors for better consistency across the codebase.
dataset_kind.rsmodules to the crates