Merged
Conversation
That3Percent
requested review from
goaaron
and removed request for
Jannis and
That3Percent
goaaron
approved these changes
Jan 26, 2022
| ) { | ||
| tracing::info!( | ||
| ray_id = %query.ray_id, | ||
| query_id = %query.id, |
Contributor
There was a problem hiding this comment.
I think that query_id and ray_id are going to be doing the same job?
Member
Author
There was a problem hiding this comment.
We can remove the query_id later
| QueryEngineError::FeesTooHigh(count) => { | ||
| format!("No suitable indexer found, {} indexers requesting higher fees for this query", count) | ||
| } | ||
| QueryEngineError::MissingBlock(_) => { |
Contributor
There was a problem hiding this comment.
For sake of logging these can be status codes I think.
| indexer_query: &IndexerQuery, | ||
| indexer: &Address, | ||
| allocation: &Address, | ||
| indexer_query: &str, |
Contributor
There was a problem hiding this comment.
how is indexer_query different from plain query?
| ) -> Result<QueryResponse, QueryEngineError> { | ||
| ) -> Result<(), QueryEngineError> { | ||
| use QueryEngineError::*; | ||
| let subgraph = query.subgraph.as_ref().unwrap().clone(); |
Contributor
There was a problem hiding this comment.
Can't you just use query as the sole function argument?
Previously, the logs used for data science and production investigations were spread across "client query result", "indexer query result", and the `indexer_response_err` fields. This collects all this information throughout the lifecycle of a query. When a response is returned to the client, there will now be a singe "Client query result" event, and a set of "Indexer attempt" events. Logs for ISA scoring remain separate.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the logs used for data science and production investigations were spread across "client query result", "indexer query result", and the
indexer_response_errfields. This collects all this information throughout the lifecycle of a query. When a response is returned to the client, there will now be a singe "Client query result" event, and a set of "Indexer attempt" events. Logs for ISA scoring remain separate.