Conversation
Theodus
changed the title
That3Percent
approved these changes
Oct 28, 2022
| .split('\n') | ||
| .filter(|l| l.trim_end() != "") | ||
| .map(|line| { | ||
| let mut csv = line.split_terminator(','); |
Contributor
There was a problem hiding this comment.
This is not a complete csv parser. Probably better to grab a crate next time.
Member
Author
There was a problem hiding this comment.
Sure, but the nice thing about CSV is that it's very easy to parse & very flexible. I think this use doesn't warrant another dependency. Though I would probably agree if I expected column headers, equal fields per record, or to support alternative delimiters.
Contributor
There was a problem hiding this comment.
Or quotes around cells that would make a , char not a delimiter...
Merged
Theodus
added a commit
that referenced
this pull request
Oct 28, 2022
# Release Notes - Load restricted deployments from file (#238)
Theodus
added a commit
that referenced
this pull request
Oct 31, 2022
Theodus
added a commit
that referenced
this pull request
Oct 31, 2022
# Release Notes - Load restricted deployments from file (#238)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.