fix: fallback to reported indexer statuses after prediction failures#359
Merged
fix: fallback to reported indexer statuses after prediction failures#359
Conversation
Merged
Theodus
added a commit
that referenced
this pull request
Jul 21, 2023
# Release Notes - fix: fallback to reported indexer statuses after prediction failures (#359) - fix: avoid duplicate indexer selections (#358) - Upgrade deps & update clippy warnings (#357) - Remove support for restricted deployments (#355) - Add some more docs for config options (#354) - refactor(graph-gateway): change crate entry point from main.rs to lib.rs (#352)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gateway's current strategy for predicting is optimized for keeping responses close to chain head. We've recently seen instances where indexers are stuck far behind chain head, potentially due to IPFS data availability issues. The gateway's predictions are not cutting it in these scenarios where
blocks_behindvalues are constantly increasing.This PR adds an exponential backoff to the
latest_blockinput to indexer selection when retries are necessary due to indexers failing to resolve the requested block hash. This also adds a more aggressive fallback based on the reported block statuses of available indexers.This is not an ideal solution, since it adds more complexity to one of the most complex interactions in the gateway. I intend to completely rework this soon. But it will likely require support on the indexer side.