feat(graph-gateway): added indexers lookup table to graph network#371
Merged
feat(graph-gateway): added indexers lookup table to graph network#371
Conversation
LNSD
force-pushed
the
feat-graph-gateway-topology-indexers-lut
branch
from
a1cf174 to
726d349
Compare
Theodus
approved these changes
Aug 11, 2023
Member
Theodus
left a comment
Theodus
left a comment
There was a problem hiding this comment.
LGTM. Just some comments about the GUID links
LNSD
force-pushed
the
feat-graph-gateway-topology-indexers-lut
branch
from
726d349 to
dbbb27f
Compare
LNSD
force-pushed
the
feat-graph-gateway-topology-indexers-lut
branch
from
dbbb27f to
63ed029
Compare
LNSD
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to chunk into smaller PRs #364 since the conflicts with the
mainbranch are making me rework certain parts.This PR adds the following increments:
GraphNetworkstruct.Indexer's URLs are guaranteed to be valid (see: 7f2f89aa-24c9-460b-ab1e-fc94697c4f4), use the indexer associatedstatu_urlandcost_urlmethods.