refactor(exchange_rate): replace eventual with watch#727
Merged
Conversation
Theodus
force-pushed
the
theodus/exchange-rate
branch
from
bf58385 to
fa2b374
Compare
Theodus
force-pushed
the
theodus/exchange-rate
branch
from
fa2b374 to
e8ee29e
Compare
LNSD
reviewed
May 9, 2024
| let (tx, mut rx) = watch::channel(NotNan::new(0.0).unwrap()); | ||
| tokio::spawn(async move { | ||
| loop { | ||
| sleep(Duration::from_secs(60)).await; |
Contributor
There was a problem hiding this comment.
I just noticed that putting the sleep at the beginning of the loop will cause an initial delay of 60 seconds to fetch the first update. This is not desirable. I'd rather put it at the end of the loop.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step in my intentions to move away from eventuals. Based on how we use them, they provide little value while making it difficult to observe using standard tokio runtime tools.