Merged
Conversation
Contributor
|
I agree with the changes made to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary goal of this PR is to increase the amount of concurrent client requests the gateway can handle before p99 latencies start to go up above the latency of indexers responding to the client requests. This happens to align with cleaning up some of the gnarliest tech debt in the gateway that we've accumulated for backwards compatibility for data science. On my local testbench, these changes more than double the amount of concurrent client requests the gateway can handle.
The biggest changes are:
client_querymodule to treat logging, metrics, feedback, kafka, etc. more clearly & deliberatelyExternal impact:
Client query result&Indexer attemptlogs we kept around for internal data science pipelines are gone. Identical field names & values have been maintained in the corresponding kafka outputs. Though some unused fields likestatus_codeandbudgethave been removed entirely.