Skip to content

feat(graph-gateway): simplify indexing info resolution#839

Merged
LNSD merged 1 commit intomainfrom
lnsd/feat-gg-simplify-indexer-processing
Jun 14, 2024
Merged

feat(graph-gateway): simplify indexing info resolution#839
LNSD merged 1 commit intomainfrom
lnsd/feat-gg-simplify-indexer-processing

Conversation

@LNSD
Copy link
Contributor

@LNSD LNSD commented Jun 14, 2024

No description provided.

@LNSD LNSD requested a review from Theodus June 14, 2024 16:56
@LNSD LNSD self-assigned this Jun 14, 2024
Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
@LNSD LNSD force-pushed the lnsd/feat-gg-simplify-indexer-processing branch from 97258eb to 5e2320a Compare June 14, 2024 16:58
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IndexerServiceVersionBelowMin(Version, Version),

/// The indexer's graph node version resolution failed.
#[error("graph-node version resolution failed: {0}")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[error("graph-node version resolution failed: {0}")]
#[error("graph node version resolution failed: {0}")]

@LNSD LNSD marked this pull request as ready for review June 14, 2024 18:16
@LNSD LNSD merged commit 80032c7 into main Jun 14, 2024
@LNSD LNSD deleted the lnsd/feat-gg-simplify-indexer-processing branch June 14, 2024 18:16
@Theodus Theodus mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants