Skip to content

feat(graph-gateway): rework network resolution error reporting#841

Merged
LNSD merged 2 commits intomainfrom
lnsd/feat-gg-error-reporting
Jun 17, 2024
Merged

feat(graph-gateway): rework network resolution error reporting#841
LNSD merged 2 commits intomainfrom
lnsd/feat-gg-error-reporting

Conversation

@LNSD
Copy link
Contributor

@LNSD LNSD commented Jun 15, 2024

This is a major code iteration with the main goal of disambiguating the error messages returned by the gateway.

  • Relocate all errors under network::errors
  • Use type-state pattern in indexer_processing module to ensure the type safety of the generated data. Refactor the code, splitting the indexing processing into a separate function
  • Relocate integration tests in-tree (it_network_internal_fetch_update)
  • Add network::config module to co-locate all config types
  • Remove various unused fields

@LNSD LNSD requested a review from Theodus June 15, 2024 09:16
@LNSD LNSD self-assigned this Jun 15, 2024
@LNSD LNSD force-pushed the lnsd/feat-gg-error-reporting branch 2 times, most recently from e2f3ff6 to 67b7e4a Compare June 15, 2024 09:29
Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
@LNSD LNSD force-pushed the lnsd/feat-gg-error-reporting branch from 67b7e4a to 263a7cf Compare June 15, 2024 09:32
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Theo Butler <theodusbutler@gmail.com>
@LNSD LNSD merged commit 68cc2b9 into main Jun 17, 2024
@LNSD LNSD deleted the lnsd/feat-gg-error-reporting branch June 17, 2024 07:53
@Theodus Theodus mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants