Skip to content

fix: remove extra configuration from network subgraph#880

Merged
Theodus merged 2 commits intomainfrom
theodus/trusted-indexers
Jul 15, 2024
Merged

fix: remove extra configuration from network subgraph#880
Theodus merged 2 commits intomainfrom
theodus/trusted-indexers

Conversation

@Theodus
Copy link
Member

@Theodus Theodus commented Jul 15, 2024

This removes the overhead of configuring fields that are functionally unused (indexer address), and avoids situations where we may want to query trusted indexers at different deployments.

@Theodus Theodus requested a review from LNSD July 15, 2024 12:33
@Theodus Theodus force-pushed the theodus/trusted-indexers branch from 0b1c2f0 to d6bd5ed Compare July 15, 2024 12:34
@Theodus Theodus mentioned this pull request Jul 15, 2024
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check my comment

Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check my comment

@Theodus Theodus requested a review from LNSD July 15, 2024 14:09
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Theodus Theodus merged commit caddd7c into main Jul 15, 2024
@Theodus Theodus deleted the theodus/trusted-indexers branch July 15, 2024 14:11
Theodus added a commit that referenced this pull request Jul 15, 2024
# Release Notes
- fix: skip POI fetch until cache TTL expires (#860)
- feat: set gateway ID to signer address (#868)
- feat: add internal query client to network subgraph service (#856,
#880)
- feat: direct indexer query API (#867)
- fix: remove deprecated data science logs (#882)

# Configuration Changes
- `gateway_id` removed
- `network_subgraph` replaced by `trusted_indexers`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants