Skip to content

fix: add optimistic progress to indexing status report #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Theodus merged 2 commits into from
Jul 16, 2024
Merged

fix: add optimistic progress to indexing status report #887

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db484e3
fix: add optimistic progress to indexing status report
Theodus Jul 16, 2024
fa71a85
fix: add missing block info
Theodus Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions graph-gateway/src/client_query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ fn build_candidates_list(
// Infer the indexed range from the indexing progress information
let range = {
let (start, end) = indexing.progress.as_range();
start.unwrap_or(0)..=max(end, perf.latest_block + blocks_per_minute)
start.unwrap_or(0)..=(max(end, perf.latest_block) + blocks_per_minute)
};

let number_gte = block_requirements.number_gte.unwrap_or(0);
Expand All @@ -644,7 +644,7 @@ fn build_candidates_list(
indexing_id.indexer,
IndexerError::Unavailable(UnavailableReason::MissingBlock(MissingBlockError {
missing: Some(missing),
latest: None,
latest: Some(max(indexing.progress.latest_block, perf.latest_block)),
})),
);
continue;
Expand Down