Enhance ParquetWriter with atomic writes and improved file naming#2
Merged
Enhance ParquetWriter with atomic writes and improved file naming#2
Conversation
Previously, parquet files were written directly to their final names, which
meant incomplete files could exist if writes were interrupted. Additionally,
the naming scheme only showed segment IDs, making it difficult to determine
actual block ranges without reading file metadata.
Changes:
- Write to .parquet.tmp files during active writing
- Atomically rename to .parquet only on successful finalization
- Enhanced naming: {topic}_{segment_start}-{segment_end}_from_{actual_start}_to_{actual_end}.parquet
- Track both theoretical segment boundaries and actual data ranges
- Remove unused Path import
Benefits:
- Incomplete files are clearly identifiable (.tmp extension)
- File names show exact block range without reading metadata
- Easy to spot files split due to size limits
- Atomic completion prevents corrupted final files
Example filenames:
- blocks_0-9999_from_0_to_9900.parquet
- blocks_500000-509999_from_500002_to_509902.parquet (split due to size)
Tested against Erigon instance with 1M block sync across 4 parallel workers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, parquet files were written directly to their final names, which meant incomplete files could exist if writes were interrupted. Additionally, the naming scheme only showed segment IDs, making it difficult to determine actual block ranges without reading file metadata.
Changes:
Benefits:
Example filenames:
Tested against Erigon instance with 1M block sync across 4 parallel workers.