Merged
Conversation
paulotruta
commented
Jun 26, 2024
Comment on lines
+431
to
+446
| // Configure the service and start it | ||
| cmd := exec.Command("sh", "/home/system/components/updater/run.sh", "--check") | ||
| stdout, err := cmd.StdoutPipe() | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| scanner := bufio.NewScanner(stdout) | ||
| err = cmd.Start() | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| for scanner.Scan() { | ||
| // fmt.Println(scanner.Text()) | ||
| text := scanner.Text() | ||
| fmt.Println(text) | ||
| } |
Member
Author
There was a problem hiding this comment.
Needs to handle not being able to run the updater. We don't want to crash in that case but gracefully exit.
Would be maybe useful to use the return_val, err := pattern commonly found in go built-in methods to return a proper error back to whatever runs CheckUpdates(). This will also allow us to mark these tasks as errors (and that thus reflected in the dashboard / api)
Member
Author
|
Still needs some cleanup work, namely better error handling and abstraction + re-use of currently repetitive code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.