Skip to content
This repository was archived by the owner on Mar 28, 2024. It is now read-only.

code: update convention syntax #51

Merged
antonioiubatti93 merged 3 commits into from
May 12, 2023
Merged

code: update convention syntax #51

antonioiubatti93 merged 3 commits into from
May 12, 2023

Conversation

@antonioiubatti93
Copy link
Contributor

@antonioiubatti93 antonioiubatti93 commented May 12, 2023

Updating a bit the code:

  • add outOfRangeConvention to check bounds in String: this avoids panicking for unknown conventions
  • upgrading to Go 1.20
  • removing unnecessary use of bytes buffer
  • adding newlines in switch

@antonioiubatti93 antonioiubatti93 added the go Pull requests that update Go code label May 12, 2023
@antonioiubatti93 antonioiubatti93 self-assigned this May 12, 2023
@antonioiubatti93 antonioiubatti93 requested a review from a team as a code owner May 12, 2023 06:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

borisdavid
borisdavid approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@borisdavid borisdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@antonioiubatti93 antonioiubatti93 merged commit 22f530b into main May 12, 2023
@antonioiubatti93 antonioiubatti93 deleted the code-update-convention-syntax branch May 12, 2023 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@borisdavid borisdavid borisdavid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antonioiubatti93 antonioiubatti93

Labels

go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonioiubatti93 @borisdavid