This repository was archived by the owner on Mar 28, 2024. It is now read-only.
perf: avoid repetitive calls to absDate #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profiling
eve, @kkrawczy noticed that a lot of time was spent in theYearFractioncomputations.Some of the functions were making use of
datemethods likeDay(),Month(),Year(). These methods make a subsequent call toabsDateeach time, which seems to be slow.This PR aims at replacing these repetitive calls by a unique call to
Date()which returns the three components needed for the year fraction compution (day, month and year).This is a tiny improvement, but every millisecond saved is a step towards our under 10s goal :)