Conversation
burgerdev
reviewed
Nov 18, 2024
Member
burgerdev
left a comment
burgerdev
left a comment
There was a problem hiding this comment.
Please also proof-read your code comments.
burgerdev
reviewed
Nov 20, 2024
Member
burgerdev
left a comment
burgerdev
left a comment
There was a problem hiding this comment.
Please make sure to also push your changes when you're resolving review comments.
jmxnzo
force-pushed
the
e2e-no-policy-jla
branch
from
728f791 to
6f53e36
Compare
Contributor
Author
I'm sorry, i was working on the issue right now and resolved the conflicts while adapting the changes to the code base. Won't happen again. |
jmxnzo
force-pushed
the
e2e-no-policy-jla
branch
from
6f53e36 to
077b95a
Compare
burgerdev
approved these changes
Nov 20, 2024
Member
burgerdev
left a comment
burgerdev
left a comment
There was a problem hiding this comment.
LGTM, but please address outstanding comments.
Member
|
Take a look at the requirements of https://github.com/edgelesssys/contrast/actions/runs/11934103702/workflow?pr=1007#L18-L24, too. Tests are usually |
jmxnzo
force-pushed
the
e2e-no-policy-jla
branch
from
077b95a to
de5ae95
Compare
burgerdev
approved these changes
Nov 21, 2024
e2e: Add waiting mechanism and correct event watching/listing to default policy test Structure changes to deploy.go e2e: rework and fetch event from the watch.Event directly e2e: Add default policy into policy test package
jmxnzo
force-pushed
the
e2e-no-policy-jla
branch
from
de5ae95 to
4b88361
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Podvms come with a default policy, which should usually be a "SetPolicy only" policy. The implemented e2e test ensures that no wrong default policy (i.e. allow-all) is included, by starting a container without any policy annotation and waiting for the Kata runtime event FailedCreatePodSandBox, which indicates that the container start failed as expected.