fix(timeline): #COCO-5341 add some log to track notification and flood trigger to debug production#969
Merged
vbillard91 merged 3 commits intodevelop-b2schoolfrom Mar 5, 2026
Conversation
…d trigger to debug production
jcbe-ode
reviewed
Mar 4, 2026
Contributor
jcbe-ode
left a comment
jcbe-ode
left a comment
There was a problem hiding this comment.
Une question + quelques suggestions
| if (sender == null || sender.startsWith("no-reply") || json.getBoolean("disableAntiFlood", false) || antiFlood.add(sender)) { | ||
| final boolean disableAntiflood = json.getBoolean("disableAntiflood", false); | ||
|
|
||
| log.info(String.format("[Timeline.add] Add new notification from sender %s with antiflood activation = %s from module %s for resources %s ", |
Contributor
There was a problem hiding this comment.
Ca va générer beaucoup de logs, non ?
Logger les cas où l'antiflood se déclenche pourrait-il suffire ?
Contributor
Author
There was a problem hiding this comment.
Une par notification, qui peut être à de multiple user. C'est nécessaire si on veut track correctement la situation sur les problèmes de "trop de notification"
timeline/src/main/java/org/entcore/timeline/controllers/TimelineController.java
Outdated
Show resolved
Hide resolved
timeline/src/main/java/org/entcore/timeline/controllers/TimelineController.java
Outdated
Show resolved
Hide resolved
Co-authored-by: jcbe-ode <67910608+jcbe-ode@users.noreply.github.com>
Co-authored-by: jcbe-ode <67910608+jcbe-ode@users.noreply.github.com>
|
jcbe-ode
approved these changes
Mar 4, 2026
vbillard91
added a commit
that referenced
this pull request
Mar 9, 2026
…d trigger to debug production (#969) # Conflicts: # timeline/src/main/java/org/entcore/timeline/controllers/TimelineController.java
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Mar 9, 2026
…d trigger to debug production (#969) # Conflicts: # timeline/src/main/java/org/entcore/timeline/controllers/TimelineController.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add logs to know when a user trigger the antiflood + log when creating a notification
Fixes
https://edifice-community.atlassian.net/browse/COCO-5341
Type of change
Please check options that are relevant.
Which packages changed?
Please check the name of the package you changed
Tests
Reminder
Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃