Skip to content

Conversation

@AlyxPractice
Copy link
Contributor

Hey, while browsing https://vim-bootstrap.com/, I was struggling mentally to match the languages/frameworks icons with their name. I thought it would be nice to add them, as it's done for the themes below.

Here's are my changes:

  • Add labels to langs & frameworks
  • Align center themes labels

Let me know if I can do something else :)


Design diff

Languages

Before
Screenshot 2022-07-22 at 12-55-48 Vim Bootstrap

After
Screenshot 2022-07-22 at 12-58-17 Vim Bootstrap

Frameworks

Before
Screenshot 2022-07-22 at 12-55-59 Vim Bootstrap

After
Screenshot 2022-07-22 at 12-57-07 Vim Bootstrap

Themes

Before
Screenshot 2022-07-22 at 12-56-16 Vim Bootstrap

After
Screenshot 2022-07-22 at 12-57-10 Vim Bootstrap

Full website

Before (open ⤵️)

Screenshot 2022-07-22 at 12-59-00 Vim Bootstrap

After (open ⤵️)

Screenshot 2022-07-22 at 12-59-13 Vim Bootstrap

@AlyxPractice
Copy link
Contributor Author

Uh looks like the style.css file was written with CRLF return line. Do you want me to revert it to CRLF or keep it in LF but create another commit to make the review easier?
Here's the diff:

$ git diff --ignore-space-change origin/main template/assets/css/style.css                                                                                                                                                                              
diff --git a/template/assets/css/style.css b/template/assets/css/style.css
index ea38c6d..4ced1a3 100755
--- a/template/assets/css/style.css
+++ b/template/assets/css/style.css
@@ -571,7 +571,7 @@

 .Highlights_cardBackground__2Fr7t {
     width: 100%;
-    height: 200px;
+    height: 220px;
     border-top-left-radius: 1rem;
     border-top-right-radius: 1rem;
     display: flex;
@@ -587,7 +587,7 @@
 .Highlights_cardDetails__v4Cip,
 .Highlights_cardDetailsContainer__8lpMI {
     display: flex;
-    flex-direction: row;
+    flex-direction: column;
     align-items: center;
     justify-content: center;
 }
@@ -869,4 +869,5 @@
     -webkit-column-count: 4;
     column-count: 4;
     display: grid;
+    text-align: center;
 }

@cassiobotaro cassiobotaro merged commit ef23fee into editor-bootstrap:main Jul 24, 2022
@cassiobotaro
Copy link
Member

@VictorBersy No worries about that, thank you !

@AlyxPractice AlyxPractice deleted the add-labels-to-icons branch July 25, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants