Conversation
…99 Gated `propagateMetadata` call in `evalGroupModifier` on `!isDropped` so dropped sub-rolls' Versus metadata no longer leaks onto the outer `RollResult.degree`. Updated inline comment to reflect kept-only propagation and the surviving `NESTED_VERSUS` collision path. Added tests covering dropped-vs-sub erasure, kept-vs-sub propagation, and the `NESTED_VERSUS` collision when two kept sub-rolls carry metadata. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gated
propagateMetadatainevalGroupModifieron!isDroppedso dropped sub-rolls' Versus metadata no longer surfaces onRollResult.degree. The unconditional propagation contradicted the invariant thatdegreemust reflect dice contributing tototal—kh/kl/dh/dlover a Group with avssub-roll could leak the dropped outcome's degree.propagateMetadatacall inif (!isDropped) { … }and rewrote the inline comment to reflect kept-only propagation and the survivingNESTED_VERSUScollision path.sub-roll mode (multi sub-roll with keep/drop): droppedvssub leavesdegreeundefined, keptvssub propagatesSuccess, two keptvssubs (3-sub group withkh2) still throwNESTED_VERSUS.Closes #99
Drafted with AI assistance