DISABLE_NATIVE_SCREENS is intentionally overridden?

[rithik-b]

Was using the flag DISABLE_NATIVE_SCREENS in blank stack, however it always used a native screen. I looked at the source and it seems to intentionally? override that so the prop never works.

https://github.com/eds2002/react-native-screen-transitions/blob/e8eb6fd13ddaf1b03272518ca6d2f117b6f7f9fb/packages/react-native-screen-transitions/src/shared/providers/stack/core.provider.tsx#L73C3-L79C5

Can I PR it to change the order? I do not want to use a native screen when using blank stack.

[eds2002]

Since component stack uses the same management system as blank stack, I figured the best way of handling both was through flags (DISABLE NATIVE SCREENS).

Originally the idea for component stack was to have it be used for embedded scenarios but blank stack could easily do this with native screens so in the next major version component stack and that annoying flag will probably be removed.

Edit:
As for not wanting to use native screens can I ask why you wouldn't want to use native screens? Idea behind it was to keep blank stack performant as possible which is why i didnt provide the option to override

[rithik-b]

ah yeah that makes sense. There is a bug with screens on android that crashes the app occasionally on native. It is hard to determine if this library is the culprit. So when I turned off screens it worked for me. For context we used to be on react-navigation/native-stack before and had similar issues with that library where we had hard to repro crashes but switching to react-navigation/stack fixed it. Anyway here is the log with the screens crash if you know what might be going on.

03-04 11:09:32.213 8495 8631 E unknown:ReactHost: Unhandled SoftException 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: com.facebook.react.bridge.ReactNoCrashSoftException: raiseSoftException(getOrCreateDestroyTask()): handleHostException(message = "FragmentManager is already executing transactions") 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.runtime.ReactHostImpl.raiseSoftException(ReactHostImpl.kt:787) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.runtime.ReactHostImpl.getOrCreateDestroyTask(ReactHostImpl.kt:1311) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.runtime.ReactHostImpl.destroy$lambda$10(ReactHostImpl.kt:473) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.runtime.ReactHostImpl.$r8$lambda$vrU67S1pce6ypI1MpEJ0yfM09iA(Unknown Source:0) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.runtime.ReactHostImpl$$ExternalSyntheticLambda35.call(D8$$SyntheticClass:0) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.runtime.internal.bolts.Task$Companion.call$lambda$2(Task.kt:315) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.runtime.internal.bolts.Task$Companion.$r8$lambda$MFqd_-X5KhHmu0hvNE2Bec_4mJM(Unknown Source:0) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.runtime.internal.bolts.Task$Companion$$ExternalSyntheticLambda1.run(D8$$SyntheticClass:0) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1154) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:652) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at java.lang.Thread.run(Thread.java:1564) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: Caused by: java.lang.IllegalStateException: FragmentManager is already executing transactions 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at androidx.fragment.app.FragmentManager.ensureExecReady(FragmentManager.java:1947) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at androidx.fragment.app.FragmentManager.execSingleAction(FragmentManager.java:1977) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at androidx.fragment.app.BackStackRecord.commitNowAllowingStateLoss(BackStackRecord.java:323) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.ScreenContainer.onUpdate(ScreenContainer.kt:441) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.ScreenContainer.performUpdates(ScreenContainer.kt:376) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.ScreenContainer.performUpdatesNow(ScreenContainer.kt:368) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.ScreenContainer.onChildUpdate(ScreenContainer.kt:96) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.Screen.setActivityState(Screen.kt:517) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.ScreenViewManager.setActivityState(ScreenViewManager.kt:121) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.ScreenViewManager.setActivityState(ScreenViewManager.kt:46) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.ScreenViewManager.setActivityState(ScreenViewManager.kt:28) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.viewmanagers.RNSScreenManagerDelegate.setProperty(RNSScreenManagerDelegate.java:116) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.uimanager.ViewManager.updateProperties(ViewManager.java:103) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.fabric.mounting.SurfaceMountingManager.updateProps(SurfaceMountingManager.java:696) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.fabric.mounting.mountitems.IntBufferBatchMountItem.execute(IntBufferBatchMountItem.kt:116) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.fabric.mounting.MountItemDispatcher.executeOrEnqueue(MountItemDispatcher.kt:312) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.fabric.mounting.MountItemDispatcher.dispatchMountItems(MountItemDispatcher.kt:221) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.fabric.mounting.MountItemDispatcher.tryDispatchMountItems(MountItemDispatcher.kt:88) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.fabric.FabricUIManager$3.runGuarded(FabricUIManager.java:913) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.bridge.GuardedRunnable.run(GuardedRunnable.kt:19) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.fabric.FabricUIManager.scheduleMountItem(FabricUIManager.java:917) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.reanimated.NativeProxy.performOperations(Native Method) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.reanimated.NodesManager.performOperations(NodesManager.java:121) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.reanimated.NodesManager.onEventDispatch(NodesManager.java:192) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.uimanager.events.FabricEventDispatcher.dispatchEvent(FabricEventDispatcher.kt:64) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.ScreenFragment.onDestroy(ScreenFragment.kt:326) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at androidx.fragment.app.Fragment.performDestroy(Fragment.java:3381) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at androidx.fragment.app.FragmentStateManager.destroy(FragmentStateManager.java:833) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:360) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at androidx.fragment.app.SpecialEffectsController$FragmentStateManagerOperation.complete$fragment_release(SpecialEffectsController.kt:846) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at androidx.fragment.app.SpecialEffectsController.commitEffects$fragment_release(SpecialEffectsController.kt:446) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at androidx.fragment.app.SpecialEffectsController.executePendingOperations(SpecialEffectsController.kt:288) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2227) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2115) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at androidx.fragment.app.FragmentManager.execSingleAction(FragmentManager.java:2002) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at androidx.fragment.app.BackStackRecord.commitNowAllowingStateLoss(BackStackRecord.java:323) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.ScreenContainer.onUpdate(ScreenContainer.kt:441) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.ScreenContainer.performUpdates(ScreenContainer.kt:376) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.ScreenContainer.onScreenChanged$lambda$8(ScreenContainer.kt:359) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.ScreenContainer.$r8$lambda$_XN8QBWatVwLAw6wNpLgWT68aTo(Unknown Source:0) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.swmansion.rnscreens.ScreenContainer$$ExternalSyntheticLambda0.run(D8$$SyntheticClass:0) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at android.os.Handler.handleCallback(Handler.java:995) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at android.os.Handler.dispatchMessage(Handler.java:103) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.kt:21) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at android.os.Looper.loopOnce(Looper.java:248) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at android.os.Looper.loop(Looper.java:338) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at android.app.ActivityThread.main(ActivityThread.java:9137) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at java.lang.reflect.Method.invoke(Native Method) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:593) 03-04 11:09:32.213 8495 8631 E unknown:ReactHost: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:940)

[eds2002]

Odd, do you think I could get the android version as well? Our e2e app uses the blank stack and I haven't seen this crash in release mode. Also is it during spam navigational events or normal navigational events

[rithik-b]

So spam helps me recreate this faster but ive seen this happen normally after some amount of time.

Odd, do you think I could get the android version as well?

If you meant source code probably not but i can try to get a minimal repro soon and see if the test app can have the same issue if you spam for long enough.