fix: remove unnecesary annotations from the hpa sync wave#117
Merged
Conversation
The HPA sync-wave patch includes annotations to indicate argocd in which order should the HPA resources be applied in relation to the other resources. The `argocd.argoproj.io/hook: Sync` and `argocd.argoproj.io/hook-delete-policy: HookSucceeded` annotations are used for ephemeral resources (like jobs) and should not be used for the HPA resources.
jfavellar90
approved these changes
Jul 2, 2024
jfavellar90
pushed a commit
that referenced
this pull request
Jul 2, 2024
The HPA sync-wave patch includes annotations to indicate argocd in which order should the HPA resources be applied in relation to the other resources. The `argocd.argoproj.io/hook: Sync` and `argocd.argoproj.io/hook-delete-policy: HookSucceeded` annotations are used for ephemeral resources (like jobs) and should not be used for the HPA resources.
jfavellar90
pushed a commit
that referenced
this pull request
Jul 2, 2024
The HPA sync-wave patch includes annotations to indicate argocd in which order should the HPA resources be applied in relation to the other resources. The `argocd.argoproj.io/hook: Sync` and `argocd.argoproj.io/hook-delete-policy: HookSucceeded` annotations are used for ephemeral resources (like jobs) and should not be used for the HPA resources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The HPA sync-wave patch includes annotations to indicate argocd in which order should the HPA resources be applied in relation to the other resources. The
argocd.argoproj.io/hook: Syncandargocd.argoproj.io/hook-delete-policy: HookSucceededannotations are used for ephemeral resources (like jobs) and should not be used for the HPA resources.Testing
Install https://github.com/eduNEXT/tutor-contrib-pod-autoscaling and activate the HPAs. The resources should be missing in the ArgoCD UI. Apply the fix and they should appear again.